Call nodeCallback with original argument with a name after reordering

phpstan · Oct 17, 2022 · ecc3076 · ecc3076
1 parent 2222b63
commit ecc3076
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Analyser/ArgumentsNormalizer.php b/src/Analyser/ArgumentsNormalizer.php
@@ -21,6 +21,8 @@
 final class ArgumentsNormalizer
 {
 
+	public const ORIGINAL_ARG_ATTRIBUTE = 'originalArg';
+
 	public static function reorderFuncArguments(
 		ParametersAcceptor $parametersAcceptor,
 		FuncCall $functionCall,
@@ -131,11 +133,13 @@ private static function reorderArgs(ParametersAcceptor $parametersAcceptor, Call
 			} elseif (array_key_exists($arg->name->toString(), $argumentPositions)) {
 				$argName = $arg->name->toString();
 				// order named args into the position the signature expects them
+				$attributes = $arg->getAttributes();
+				$attributes[self::ORIGINAL_ARG_ATTRIBUTE] = $arg;
 				$reorderedArgs[$argumentPositions[$argName]] = new Arg(
 					$arg->value,
 					$arg->byRef,
 					$arg->unpack,
-					$arg->getAttributes(),
+					$attributes,
 					null,
 				);
 			}

diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -3265,7 +3265,8 @@ private function processArgs(
 		$hasYield = false;
 		$throwPoints = [];
 		foreach ($args as $i => $arg) {
-			$nodeCallback($arg, $scope);
+			$originalArg = $arg->getAttribute(ArgumentsNormalizer::ORIGINAL_ARG_ATTRIBUTE) ?? $arg;
+			$nodeCallback($originalArg, $scope);
 			if (isset($parameters) && $parametersAcceptor !== null) {
 				$assignByReference = false;
 				if (isset($parameters[$i])) {