RangeFunctionReturnTypeExtension - fix internal ValueError

phpstan · May 15, 2024 · fe3895a · fe3895a
1 parent 7ef210c
commit fe3895a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/src/Type/Php/RangeFunctionReturnTypeExtension.php b/src/Type/Php/RangeFunctionReturnTypeExtension.php
@@ -65,6 +65,11 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 						continue;
 					}
 
+					$rangeSpanned = abs($endConstant->getValue() - $startConstant->getValue());
+					if ($rangeSpanned <= $stepConstant->getValue()) {
+						continue;
+					}
+
 					$rangeValues = range($startConstant->getValue(), $endConstant->getValue(), $stepConstant->getValue());
 					if (count($rangeValues) > self::RANGE_LENGTH_THRESHOLD) {
 						if ($startConstant instanceof ConstantIntegerType && $endConstant instanceof ConstantIntegerType) {

diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -1348,6 +1348,12 @@ public function testBug10979(): void
 		$this->assertNoErrors($errors);
 	}
 
+	public function testBug11026(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-11026.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]

diff --git a/tests/PHPStan/Analyser/data/bug-11026.php b/tests/PHPStan/Analyser/data/bug-11026.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace Bug11026;
+
+function (): void {
+	$a = range(1, 3/2);
+};