Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.4 compile error - php_strtolower not declared #540

Open
rbro opened this issue Oct 24, 2024 · 0 comments
Open

php 8.4 compile error - php_strtolower not declared #540

rbro opened this issue Oct 24, 2024 · 0 comments

Comments

@rbro
Copy link
Contributor

rbro commented Oct 24, 2024

When compiling v8js against PHP 8.4.0RC3, I got the below error:

/tmp/v8js/v8js_object_export.cc:678:9: error: ‘php_strtolower’ was not declared in this scope; did you mean ‘php_strtok_r’?

I found the below change in PHP:

php/php-src@85e6688

Also, I found this reference:

Imagick/imagick#690

I tried a quick test and changing v8js_object_export.cc to call zend_str_tolower instead of php_strtolower seems to work.

Thanks for your help.

JoshuaBehrens added a commit to JoshuaBehrens/v8js that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant