allow non 200 HTTP return code to be OK, fixes #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xorpaul
force-pushed
the
allow_non_200_http_code
branch
from
3afc365
to
a5973eb
Compare
phrawzty
approved these changes
Aug 17, 2021
|
Looks great! Thanks for the PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using it to detect if my vault nodes are unsealed.
Standby nodes in HA mode return 429 instead of 200, which is intended by vault (hashicorp/vault#2850)
The default behavior stops validating the JSON output as soon as
--status_level 429:0is specified: