Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controlling Landlock ABI versions #41

Closed
wants to merge 9 commits into from
Closed

Conversation

cd-work
Copy link
Collaborator

@cd-work cd-work commented Sep 1, 2023


This requires a new Landlock release before getting merged.

@cd-work cd-work force-pushed the landlock_versioning branch from 855bb53 to 8204f8e Compare September 1, 2023 18:20
src/linux/mod.rs Outdated Show resolved Hide resolved
src/linux/mod.rs Outdated Show resolved Hide resolved
Copy link

@l0kod l0kod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the 4 UML kernels provided by https://github.com/landlock-lsm/landlock-test-tools and make sure that Birdcage supports them all by tweaking you CI like this: landlock-lsm/rust-landlock#41 (and the following changes)

src/linux/mod.rs Show resolved Hide resolved
src/linux/mod.rs Show resolved Hide resolved
src/linux/mod.rs Outdated Show resolved Hide resolved
@cd-work
Copy link
Collaborator Author

cd-work commented Sep 12, 2023

You can use the 4 UML kernels provided by https://github.com/landlock-lsm/landlock-test-tools and make sure that Birdcage supports them all by tweaking you CI like this: landlock-lsm/rust-landlock#41 (and the following changes)

I've never heard of UML before, but this is genuinely amazing. Thanks for dropping those links.

@cd-work cd-work force-pushed the landlock_versioning branch from 40ec500 to aad0bef Compare September 15, 2023 20:26
@cd-work cd-work marked this pull request as ready for review September 15, 2023 20:27
@cd-work cd-work requested a review from kylewillmon September 18, 2023 18:25
kylewillmon
kylewillmon previously approved these changes Sep 18, 2023
@@ -56,7 +61,7 @@ harness = false

[target.'cfg(target_os = "linux")'.dependencies]
seccompiler = "0.2.0"
landlock = "0.2.0"
landlock = { git = "https://github.com/landlock-lsm/rust-landlock" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until a new landlock version is released.

@kylewillmon kylewillmon dismissed their stale review September 18, 2023 19:53

PR awaiting landlock release

@cd-work
Copy link
Collaborator Author

cd-work commented Sep 28, 2023

Closed in favor of #47.

@cd-work cd-work closed this Sep 28, 2023
@cd-work cd-work deleted the landlock_versioning branch September 28, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants