Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make heuristics a simple set of "if .. elif .. else" statements and use a dictionary instead of variables. #209

Merged
merged 21 commits into from
Apr 22, 2020
Merged

Make heuristics a simple set of "if .. elif .. else" statements and use a dictionary instead of variables. #209

merged 21 commits into from
Apr 22, 2020

Commits on Apr 10, 2020

  1. Start from 1 in run numeration

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    cd55bf0 View commit details
    Browse the repository at this point in the history

  2. Delete heur_ex and heur

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    38a7142 View commit details
    Browse the repository at this point in the history

  3. Restructure heuristics to use info dictionary

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    c4e62b8 View commit details
    Browse the repository at this point in the history

  4. Adapt use_heuristic to accept new heuristics and use info dictionary

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    2f9146a View commit details
    Browse the repository at this point in the history

  5. Update heuristics for tutorial and tests

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    fbc30fd View commit details
    Browse the repository at this point in the history

  6. Update documentation

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    28570e8 View commit details
    Browse the repository at this point in the history

  7. Correct folder path

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    7abb36e View commit details
    Browse the repository at this point in the history

  8. Update tests to match new heuristic (run-00→01)

    Stefano Moia committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    bd46897 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Change dictionary name from 'info' to 'bids_keys'

    Stefano Moia committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    447c176 View commit details
    Browse the repository at this point in the history

  2. Add pytest parametrisation not to loose coverage

    Stefano Moia committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    a7cf2c6 View commit details
    Browse the repository at this point in the history

  3. Change file link for deleted file

    Stefano Moia committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    e21c138 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Update phys2bids/phys2bids.py 

    Co-Authored-By: Ross Markello <rossmarkello@gmail.com>
    @rmarkello
    Stefano Moia and rmarkello authored Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c9a54e1 View commit details
    Browse the repository at this point in the history

  2. Update phys2bids/phys2bids.py 

    Co-Authored-By: Ross Markello <rossmarkello@gmail.com>
    @rmarkello
    Stefano Moia and rmarkello authored Apr 20, 2020
    Configuration menu
    Copy the full SHA
    0ba2ec5 View commit details
    Browse the repository at this point in the history

  3. Update docs/heuristic.rst 

    Co-Authored-By: Ross Markello <rossmarkello@gmail.com>
    @rmarkello
    Stefano Moia and rmarkello authored Apr 20, 2020
    Configuration menu
    Copy the full SHA
    8158e41 View commit details
    Browse the repository at this point in the history

  4. Update phys2bids/phys2bids.py 

    Co-Authored-By: Ross Markello <rossmarkello@gmail.com>
    @rmarkello
    Stefano Moia and rmarkello authored Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c0d9954 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Remove logger from heuristic, initialise dictionary internally rather… 

    … than passing it as an argument
    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    4eecc21 View commit details
    Browse the repository at this point in the history

  2. Add logger that was in the heuristics before, update dictionary inste… 

    …ad of reassigning it.
    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6c94afe View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/enh/heuristic_refactor' into enh… 

    …/heuristic_refactor
    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    ebe5614 View commit details
    Browse the repository at this point in the history

  4. Tiny parenthesis matter

    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    34fa496 View commit details
    Browse the repository at this point in the history

  5. Update documentations

    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    2d64201 View commit details
    Browse the repository at this point in the history

  6. It's always the whitespaces. Always.

    Stefano Moia committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    3387c34 View commit details
    Browse the repository at this point in the history