Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Various Cleanup #13

Merged
merged 9 commits into from
Oct 12, 2023
Merged

[Fix] Various Cleanup #13

merged 9 commits into from
Oct 12, 2023

Conversation

hklee93
Copy link
Contributor

@hklee93 hklee93 commented Sep 27, 2023 •
edited
Loading

  • renaming pi_network.rb to pinetwork.rb to match gem name
  • adding errors.rb file to the spec file
  • adding a missing end keyword
  • fixing a typo
  • use payment_id as param for consistency

@hklee93 hklee93 changed the title Adding errors.rb to files list [Fix] Various Cleanup Oct 2, 2023
@aurelienshz aurelienshz merged commit a8a73cf into main Oct 12, 2023
@aurelienshz aurelienshz deleted the fix/spec-files branch October 12, 2023 16:52
@aurelienshz aurelienshz restored the fix/spec-files branch October 12, 2023 16:53
@aurelienshz aurelienshz deleted the fix/spec-files branch October 12, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam12232 adam12232 adam12232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hklee93 @adam12232 @aurelienshz