Enable history and auto-completion for embedded SQLite3 engine

[DL6ER]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10

---

See title. Everything was already configured correctly, we just needed to enable the feature. For the sake of simplicity, we use the history of sqlite3 so you can immediately use pihole-FTL sql with your recent history. Auto-completion is available though Tab, as usual.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/sqlite3-autocomplete/52530/2

[yubiuser]

Add -DHAVE_READLINE and the -lreadline and -lncurses libraries to get command-line editing support.

https://www.sqlite.org/howtocompile.html

Do we have those "-lreadline and -lncurses libraries" inclueded?

[DL6ER]

Yes, ncurses isn't needed, readline is added here:

FTL/src/CMakeLists.txt

Lines 206 to 213 in 7387e81

	find_library(LIBREADLINE NAMES libreadline${CMAKE_STATIC_LIBRARY_SUFFIX} readline)
	find_library(LIBHISTORY NAMES libhistory${CMAKE_STATIC_LIBRARY_SUFFIX} history)
	find_library(LIBTERMCAP NAMES libtermcap${CMAKE_STATIC_LIBRARY_SUFFIX} termcap)
	if(LIBREADLINE AND LIBHISTORY AND LIBTERMCAP)
	message(STATUS "Building FTL with readline support: YES")
	target_compile_definitions(FTL PRIVATE LUA_USE_READLINE)
	target_compile_definitions(pihole-FTL PRIVATE LUA_USE_READLINE)
	target_link_libraries(pihole-FTL ${LIBREADLINE} ${LIBHISTORY} ${LIBTERMCAP})

[yubiuser]

Approving. Please wait for feedback from discourse before merging.

[yubiuser]

Reported to be working on discourse:
https://discourse.pi-hole.net/t/sqlite3-autocomplete/52530/4?u=yubiuser

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1