Use embedded SQLite3 engine for the tests #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tever the system may be providing Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
commented
Jan 18, 2022
| @@ -213,7 +213,7 @@ INSERT INTO adlist VALUES(1,'https://hosts-file.net/ad_servers.txt',1,1559928803 | |||
| INSERT INTO gravity VALUES('whitelisted.ftl',1); | |||
| INSERT INTO gravity VALUES('gravity.ftl',1); | |||
| INSERT INTO gravity VALUES('gravity-whitelisted.ftl',1); | |||
| INSERT INTO info VALUES("gravity_count",3); | |||
| INSERT INTO info VALUES('gravity_count',3); | |||
There was a problem hiding this comment.
Changed because of
As of SQLite 3.27.0 (2019-02-07) the use of a double-quoted string literal causes a warning message to be sent to the error log.
yubiuser
approved these changes
Jan 18, 2022
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
This was referenced Feb 12, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Use FTLs embedded SQLite3 engine for the tests instead of relying whatever the system may be providing. This exclusively affects tests. Nothing is changed in FTL itself.