-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add others section to upstream servers pie chart #1284
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add something here:
Lines 723 to 726 in 7387e81
if(strcmp(forwarddest, "cache") == 0) | |
forwarddestid = -1; | |
else if(strcmp(forwarddest, "blocklist") == 0) | |
forwarddestid = -2; |
Clicking on the new upstream "other" opens the query log but no queries are found.
If adding "-3" here: I promised Promo pi-hole/web#1594 |
This shouldn't make any difference, the order is not changed. |
69cdfe9
to
36ffc48
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
4679459
to
6a11211
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/wrong-percent-calculation-in-pie-chart-v2/53599/5 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/plotzlich-ein-unbekannter-upstream-server-im-dashboard/60623/2 |
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
There are queries which are neither sent upstream nor are they cached or blocked. These are incorrectly ignored in the upstream server pie chart leading to a mismatch of the blocked percentage compared to the value reported at the top. Even when both are correct (their difference is caused by different reference frames), this is confusing. To compensate, we add a new type
other
which summarizes all these queries, causing the two reference frames to be identical.