Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust query type counters when importing from the database #1317

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 18, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Fixes #1315

@DL6ER DL6ER added the Bugfix label Mar 18, 2022
@DL6ER DL6ER linked an issue Mar 18, 2022 that may be closed by this pull request
@DL6ER DL6ER marked this pull request as ready for review March 18, 2022 19:35
@DL6ER DL6ER requested a review from a team March 18, 2022 19:35
@DL6ER
Copy link
Member Author

DL6ER commented Mar 18, 2022

Confirmed working by OP in #1315

@yubiuser yubiuser merged commit 7e45549 into development Mar 18, 2022
@yubiuser yubiuser deleted the fix/negative_replies branch March 18, 2022 19:58
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API returns negative values for some reply types
3 participants