Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELAY_STARTUP only when booting #1349

Merged
merged 2 commits into from
Jun 12, 2022
Merged

DELAY_STARTUP only when booting #1349

merged 2 commits into from
Jun 12, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 19, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Apply DELAY_STARTUP only when the system is still booting. The amount of time we consider a system still booting is a compile-time constant. It defaults to 60 seconds.

… of time we consider a system still booting is a compile-time constant. It defaults to 60 seconds.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file a documentation PR to adjust
https://docs.pi-hole.net/ftldns/configfile/#delay_startup

src/FTL.h Outdated Show resolved Hide resolved
src/daemon.c Outdated Show resolved Hide resolved
Co-authored-by: yubiuser <ckoenig@posteo.de>
@dschaper dschaper self-assigned this May 19, 2022
@dschaper
Copy link
Member

Assigned myself for documentation.

@yubiuser
Copy link
Member

yubiuser commented Jun 7, 2022

Pinging @dschaper for documentation.

@yubiuser
Copy link
Member

Documentation: pi-hole/docs#725

@yubiuser yubiuser merged commit 9021578 into development Jun 12, 2022
@yubiuser yubiuser deleted the tweak/delay_uptime branch June 12, 2022 14:31
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/separate-startup-delay-and-the-delay-after-reboot/53427/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants