Allowing underscore and hyphen in any position for gravity parseList #1563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
This PR allows parsing domains using hyphens and/or underscores in non-standard positions, allowing Pi-hole to block them.
Background:
The RFC standards allow underscores and hyphens only in specific positions on a domain name.
The
gravity_parseList()
function discards domains not following the rules defined these standards, but there are real domains using these patterns.Some lists contain these non-standard domains, but Pi-hole is currently discarding/ignoring them.
How does this PR accomplish the above?:
Using a less restrictive pattern.
Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase
)