Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pihole-FTL sqlite3 -ni #1820

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Add pihole-FTL sqlite3 -ni #1820

merged 2 commits into from
Dec 9, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 9, 2023

What does this implement/fix?

This is the v5 backport of #1819. All info therein. We will not add CI tests here but have them in the other PR.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ssible via "-ni"

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team December 9, 2023 20:32
src/args.c Outdated Show resolved Hide resolved
Co-authored-by: yubiuser <ckoenig@posteo.de>
Signed-off-by: Dominik <DL6ER@users.noreply.github.com>
@DL6ER DL6ER merged commit a86ea8f into development Dec 9, 2023
20 checks passed
@DL6ER DL6ER deleted the new/sql_ni_v5 branch December 9, 2023 21:59
@DL6ER DL6ER mentioned this pull request Dec 10, 2023
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-24-and-core-v5-17-3-released/67486/1

PrivatePuffin referenced this pull request in truecharts/public Jan 9, 2024
…c4 by renovate (#17027)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [pihole/pihole](https://github.com/pi-hole/docker-pi-hole) | major |
`2023.11.0` -> `2024.01.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pi-hole/docker-pi-hole (pihole/pihole)</summary>

###
[`v2024.01.0`](https://github.com/pi-hole/docker-pi-hole/releases/tag/2024.01.0)

[Compare
Source](https://github.com/pi-hole/docker-pi-hole/compare/2023.11.0...2024.01.0)

Nothing docker specific this time around.

<!-- Release notes generated using configuration in .github/release.yml
at development -->

#### What's Changed (FTL v5.24)

- Update dependabot.yml by
[@&#8203;PromoFaux](https://github.com/PromoFaux) in
[https://github.com/pi-hole/FTL/pull/1587](https://github.com/pi-hole/FTL/pull/1587)
- Add pihole-FTL sqlite3 -ni by
[@&#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1820](https://github.com/pi-hole/FTL/pull/1820)
- Fix possible crash with high client activity by
[@&#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1777](https://github.com/pi-hole/FTL/pull/1777)
- Implement special domains whitelisting by
[@&#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1808](https://github.com/pi-hole/FTL/pull/1808)

**Full Changelog**: pi-hole/FTL@v5.23...v5.24

<!-- Release notes generated using configuration in .github/release.yml
at development -->

#### What's Changed (Core v5.17.3)

- Add "-ni" to all sqlite3 invocations (v5) by
[@&#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/pi-hole/pull/5519](https://github.com/pi-hole/pi-hole/pull/5519)

**Full Changelog**:
pi-hole/pi-hole@v5.17.2...v5.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjYuMiIsInVwZGF0ZWRJblZlciI6IjM3LjEyNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
GabrielBarzen referenced this pull request in GabrielBarzen/charts Feb 2, 2024
…c4 by renovate (truecharts#17027)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [pihole/pihole](https://github.com/pi-hole/docker-pi-hole) | major |
`2023.11.0` -> `2024.01.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pi-hole/docker-pi-hole (pihole/pihole)</summary>

###
[`v2024.01.0`](https://github.com/pi-hole/docker-pi-hole/releases/tag/2024.01.0)

[Compare
Source](https://github.com/pi-hole/docker-pi-hole/compare/2023.11.0...2024.01.0)

Nothing docker specific this time around.

<!-- Release notes generated using configuration in .github/release.yml
at development -->

#### What's Changed (FTL v5.24)

- Update dependabot.yml by
[@&truecharts#8203;PromoFaux](https://github.com/PromoFaux) in
[https://github.com/pi-hole/FTL/pull/1587](https://github.com/pi-hole/FTL/pull/1587)
- Add pihole-FTL sqlite3 -ni by
[@&truecharts#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1820](https://github.com/pi-hole/FTL/pull/1820)
- Fix possible crash with high client activity by
[@&truecharts#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1777](https://github.com/pi-hole/FTL/pull/1777)
- Implement special domains whitelisting by
[@&truecharts#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/FTL/pull/1808](https://github.com/pi-hole/FTL/pull/1808)

**Full Changelog**: pi-hole/FTL@v5.23...v5.24

<!-- Release notes generated using configuration in .github/release.yml
at development -->

#### What's Changed (Core v5.17.3)

- Add "-ni" to all sqlite3 invocations (v5) by
[@&truecharts#8203;DL6ER](https://github.com/DL6ER) in
[https://github.com/pi-hole/pi-hole/pull/5519](https://github.com/pi-hole/pi-hole/pull/5519)

**Full Changelog**:
pi-hole/pi-hole@v5.17.2...v5.17.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjYuMiIsInVwZGF0ZWRJblZlciI6IjM3LjEyNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants