-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pi-hole FTL v5.2 #853
Merged
Merged
Pi-hole FTL v5.2 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <dl6er@dl6er.de>
Improve FTL tests
…in that caused blocking the entire CNAME chain. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…ase during import. This ensures restarting FTL does not mean we lost this information. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
… CNAME chain are already in the cache Signed-off-by: DL6ER <dl6er@dl6er.de>
…This also simplifies the terminology in the CNAME inspection routine. Signed-off-by: DL6ER <dl6er@dl6er.de>
…ger." This reverts commit af9107a.
Release/v5.1 -> development
…independtly from opening IPv4 and/or IPv6 sockets. Also, we cannot delete the port in close_telnet_port() as this function is called by TCP workers since v5.1 so we'd loose the port file when the first TCP query comes in. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Revert "Remove portfile not used by the current web interface any longer"
Import test fix from development
…ogress. This has been observed with clients clsoing their connection exactly at the same time when dnsmasq wants to close the connection itself due to a timeout (it thinks this client is stale). Signed-off-by: DL6ER <dl6er@dl6er.de>
…ssage: "TCP worker forked for client 192.168.0.42 on interface enp0s25 (192.168.0.12)" Signed-off-by: DL6ER <dl6er@dl6er.de>
… RFC 1035 says: "If the server needs to close a dormant connection to reclaim resources, it should wait until the connection has been idle for a period on the order of two minutes." We are unlikely to run into a limit here as the total number of allowed TCP workers is fixed as well. Signed-off-by: DL6ER <dl6er@dl6er.de>
…ve seen reports where 20 wasn't sufficient in user networks. Given that TCP workers do not really consume all that much more memory, this limit may even be increased further in case we recognize that 60 still isn't sufficient. Signed-off-by: DL6ER <dl6er@dl6er.de>
…g() cannot run two times even when called exactly at the same time. Signed-off-by: DL6ER <dl6er@dl6er.de>
…requests (performed from independent threads). Signed-off-by: DL6ER <dl6er@dl6er.de>
…ation_crash Improve TCP worker handling
…S-cache entries. Signed-off-by: DL6ER <dl6er@dl6er.de>
… compilation speed. Signed-off-by: DL6ER <dl6er@dl6er.de>
Enhance reload speed
Safely reopen gravity database
Add logging for CNAME inspection
Make FTL builds faster
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Also remove floor on valid and preffered times in RA when no time is specified. Signed-off-by: DL6ER <dl6er@dl6er.de>
Update embedded dnsmasq to v2.82
2 tasks
dschaper
previously approved these changes
Jul 26, 2020
…tch was harmless, however, it prevented regex ID from being loaded from the database. Signed-off-by: DL6ER <dl6er@dl6er.de>
This PR can be un-drafted after merging #857 |
Fix rare database importing issue
dschaper
previously approved these changes
Aug 4, 2020
PromoFaux
previously approved these changes
Aug 4, 2020
Signed-off-by: DL6ER <dl6er@dl6er.de>
Closed
3 tasks
Create and use a temporary copy of the domain string during the analysis
dschaper
approved these changes
Aug 9, 2020
PromoFaux
approved these changes
Aug 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Pi-hole v5.2 release.
This release includes all changes merged into v5.1.1 (not release individually!) plus the upgrade to dnsmasq v2.82
Highlights
pihole -c
) Revert "Remove portfile not used by the current web interface any longer" #838dnsmasq
default) to 300 seconds to not kill connections too earlydnsmasq
default) to 60pihole restartdns reload
and... reload-lists
speed Enhance reload speed #850