Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-hole FTL v5.2 #853

Merged
merged 44 commits into from
Aug 9, 2020
Merged

Pi-hole FTL v5.2 #853

merged 44 commits into from
Aug 9, 2020

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 24, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Pi-hole v5.2 release.

This release includes all changes merged into v5.1.1 (not release individually!) plus the upgrade to dnsmasq v2.82

Highlights

DL6ER and others added 30 commits July 7, 2020 22:23
…in that caused blocking the entire CNAME chain.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…ase during import. This ensures restarting FTL does not mean we lost this information.

Signed-off-by: DL6ER <dl6er@dl6er.de>
… CNAME chain are already in the cache

Signed-off-by: DL6ER <dl6er@dl6er.de>
…This also simplifies the terminology in the CNAME inspection routine.

Signed-off-by: DL6ER <dl6er@dl6er.de>
…independtly from opening IPv4 and/or IPv6 sockets. Also, we cannot delete the port in close_telnet_port() as this function is called by TCP workers since v5.1 so we'd loose the port file when the first TCP query comes in.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Revert "Remove portfile not used by the current web interface any longer"
Import test fix from development
…ogress. This has been observed with clients clsoing their connection exactly at the same time when dnsmasq wants to close the connection itself due to a timeout (it thinks this client is stale).

Signed-off-by: DL6ER <dl6er@dl6er.de>
…ssage: "TCP worker forked for client 192.168.0.42 on interface enp0s25 (192.168.0.12)"

Signed-off-by: DL6ER <dl6er@dl6er.de>
… RFC 1035 says: "If the server needs to close a dormant connection to reclaim resources, it should wait until the connection has been idle for a period on the order of two minutes." We are unlikely to run into a limit here as the total number of allowed TCP workers is fixed as well.

Signed-off-by: DL6ER <dl6er@dl6er.de>
…ve seen reports where 20 wasn't sufficient in user networks. Given that TCP workers do not really consume all that much more memory, this limit may even be increased further in case we recognize that 60 still isn't sufficient.

Signed-off-by: DL6ER <dl6er@dl6er.de>
…g() cannot run two times even when called exactly at the same time.

Signed-off-by: DL6ER <dl6er@dl6er.de>
…requests (performed from independent threads).

Signed-off-by: DL6ER <dl6er@dl6er.de>
…S-cache entries.

Signed-off-by: DL6ER <dl6er@dl6er.de>
… compilation speed.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Also remove floor on valid and preffered times in RA when
no time is specified.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Release label Jul 24, 2020
@DL6ER DL6ER added this to the v5.2 milestone Jul 24, 2020
@DL6ER DL6ER requested review from dschaper, PromoFaux and a team July 25, 2020 20:05
@DL6ER DL6ER marked this pull request as ready for review July 25, 2020 20:05
@DL6ER DL6ER mentioned this pull request Jul 26, 2020
2 tasks
dschaper
dschaper previously approved these changes Jul 26, 2020
…tch was harmless, however, it prevented regex ID from being loaded from the database.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER marked this pull request as draft August 3, 2020 17:48
@DL6ER
Copy link
Member Author

DL6ER commented Aug 3, 2020

This PR can be un-drafted after merging #857

@DL6ER DL6ER marked this pull request as ready for review August 4, 2020 03:48
@DL6ER DL6ER requested a review from dschaper August 4, 2020 03:48
dschaper
dschaper previously approved these changes Aug 4, 2020
PromoFaux
PromoFaux previously approved these changes Aug 4, 2020
Create and use a temporary copy of the domain string during the analysis
@DL6ER DL6ER dismissed stale reviews from PromoFaux and dschaper via 3414def August 9, 2020 20:59
@DL6ER DL6ER requested review from PromoFaux and dschaper August 9, 2020 21:00
@PromoFaux PromoFaux merged commit dbd4a69 into master Aug 9, 2020
@DL6ER DL6ER deleted the release/v5.2 branch September 10, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants