Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Podman and S6 overlay #1181

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Fix issues with Podman and S6 overlay #1181

merged 1 commit into from
Aug 25, 2022

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Should fix : #1176

TL;DR:

Before I updated the version of s6-overlay in the container, there was this line that moved /init to /s6-init, and the entrypoint was set to /s6-init.

I've just tested reverting this change (here: 18360d1), and pushed a new image with the :exp tag

Can you folk that are running into issues with podman please try pihole/pihole:exp and report back? Thanks!

(From a very brief test on my UDM running podman, it at least starts the container)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team August 25, 2022 18:29
@PromoFaux PromoFaux added the bug label Aug 25, 2022
…nts to make sure it does not get removed again

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux merged commit 471e042 into dev Aug 25, 2022
@PromoFaux PromoFaux deleted the fix-podman-issues branch August 25, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants