Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for empty values in the PIHOLE_DNS_ array, skip if it's empty #1185

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Test for empty values in the PIHOLE_DNS_ array, skip if it's empty #1185

merged 1 commit into from
Aug 27, 2022

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Addresses a potential issue brought up here: #1174 (comment)

(includes some indentation changes because that was wrong - hide whitespace when reviewing for clarity)

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team August 26, 2022 21:42
@PromoFaux
Test for empty values in the PIHOLE_DNS_ array, skip if it's empty
939a69b 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux merged commit 9d0162e into dev Aug 27, 2022
@PromoFaux PromoFaux deleted the tweak/PIHOLE_DNS_ARR branch August 27, 2022 07:16
@corasaniti corasaniti mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PromoFaux @rdwebdesign