v5 : php script sub.php is missing

[coop-git]

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:
8, I can read/write PHP

---

Expected behaviour:

Domains are removed from the whitelist/blacklist when making a POST to admin/api.php?list=black&sub=domain.com
admin/api.php?list=black&add=domain.com works fine

Actual behaviour:

Domains are not added to blacklist when making a POST to admin/api.php?list=black&sub=domain.com

Steps to reproduce:

do a POST to admin/api.php?list=black&add=domain.com
Check blacklist: domain is added : OK
do a POST to admin/api.php?list=black&sub=domain.com
Check blacklist : domain is still there NOK

Troubleshooting undertaken, and/or other relevant information:

Opened api.php to see what it refers to
It refers to add.php and sub.php
add.php is available but sub.php is missing.

[Scratchcat1]

The same applies for making a GET request to admin/api.php?list. The request errors out because get.php is also missing.

[PromoFaux]

Looks like the files were removed in this pull request

#1154

@DL6ER , is the idea here that folks consuming the API should use groups.php instead?

[DL6ER]

Maybe I wasn't aware of the possibility to add and remove domains through the API, at least I'm aware of this feature right now. groups.php should be a more than adequate alternative, however, authentication may be an issue.

I cannot submit a patch myself for a few days, neither can I test things, so you won't see a fix for this from me.

[PromoFaux]

No rush, enjoy yourself! I may even look at it if I have some time

[pralor-bot]

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/black-whitelisting-does-not-work-on-v5-api/33119/2

[pralor-bot]

This issue has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1