-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pi-hole web v5.1 #1480
Merged
Merged
Pi-hole web v5.1 #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a Bootstrap 4.x class. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Set default sort on DHCP lease tables to that of Hostname for ease of Access
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Improve nav-tabs accessibility and minor cleanup
Also switch to double quotes Signed-off-by: XhmikosR <xhmikosr@gmail.com>
…mooth charts Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
require auth for the customDNS page
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
* fix "Pi-hole" case * remove moot modal class Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
The previous solution did not delete the cookie. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Missed font-display
auditlog: fix buttons grouping
Move non-Bootstrap files outside of the bootstrap folder
Load the built DataTables bundle
Add .gitattributes file
Remove glyphicons again.
Update settings.js
index.php: make query charts smaller on md
Co-authored-by: Adam Warner <me@adamwarner.co.uk>
…g this logic change prevents a misleading message being displayed to the user Signed-off-by: Adam Warner <me@adamwarner.co.uk>
… if it is specified by the user Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Only show query types for which the count is larger than zero
Co-authored-by: Adam Warner <me@adamwarner.co.uk>
Tweak/custom dns
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Remove HTML from titles when not needed.
Update devDependencies and regenerate package-lock.json
Improve conditional forwarding settings
Bumps [xo](https://github.com/xojs/xo) from 0.32.0 to 0.32.1. - [Release notes](https://github.com/xojs/xo/releases) - [Commits](xojs/xo@v0.32.0...v0.32.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
DL6ER
previously approved these changes
Jul 6, 2020
We are down to 0 vulnerabilities again. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR
approved these changes
Jul 14, 2020
One more approval needed here, please |
DL6ER
approved these changes
Jul 15, 2020
9 tasks
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Tweaks
type="button"
to all buttons. Addtype="button"
to all buttons. #1262 (@XhmikosR)text-uppercase
in sidebar Usetext-uppercase
in sidebar #1319 (@XhmikosR)hidden
attribute does not need a value. HTMLhidden
attribute does not need a value. #1301 (@XhmikosR)no-zero-fractions
rule Enableno-zero-fractions
rule #1298 (@XhmikosR)fa5
class on the sidebar toggle Usefa5
class on the sidebar toggle #1368 (@XhmikosR)!== -1
to check for a string's existence Always use!== -1
to check for a string's existence #1372 (@XhmikosR)data
for null before trying to manipulate it. Checkdata
for null before trying to manipulate it. #1398 (@PromoFaux )$.each
with native methods. Replace$.each
with native methods. #1384 (@XhmikosR)$
instead ofjQuery
. Use$
instead ofjQuery
. #1385 (@XhmikosR)gethostname()
calls Guardgethostname()
calls #1400 (@XhmikosR)div
Remove duplicate tokendiv
#1390 (@XhmikosR)eslint-plugin-compat
Addeslint-plugin-compat
#1403 (@XhmikosR)prop()
for thedisabled
attribute. Useprop()
for thedisabled
attribute. #1406 (@XhmikosR)removeAttr()
withprop()
gravity.js: replaceremoveAttr()
withprop()
#1407 (@XhmikosR)$(fn)
Use$(fn)
#1408 (@XhmikosR)utils.datetime()
network.js: useutils.datetime()
#1452 (@XhmikosR)Fixes
aria-expanded
for user-menu dropdown header: fixaria-expanded
for user-menu dropdown #1304 (@XhmikosR)persistentlogin
cookie Properly delete thepersistentlogin
cookie #1350 (@XhmikosR)