Update adminLTE to 2.4.18

[PromoFaux]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes, and have included unit tests where possible.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)

---

What does this PR aim to accomplish?:

• Change a few references per upgrade guide
• define colors[] at the top of index.js as AdminLTE.options does not appear to exist. (there may be a better way of doing this)

Alternative to #1271, which does the same thing but modifies an older version of AdminLTE

Both paths achieve the same thing.

All credit due to @roccivic who took the time to triage the responsiveness issue

[XhmikosR]

I wonder maybe we could update to the latest 2.x version while at it?

Assuming you tested the changes, then the remaining diff is this: ColorlibHQ/AdminLTE@v2.4.12...v2.4.18

I cannot test this myself, but if it works for you guys go ahead. BTW feel free to squash my patch :)

[DL6ER]

Something is strange here, look at the colors in this graph:

So I cleared my cache and reloaded the page and everything seemed to be back to normal:

However, when reloading (with or without flushing the cache), I can reproduce both variants here in a seemingly nondeterministic fashion.

edit

This also applies to the other doughnut, however, not the bar graphs, it seems.

edit 2

I see what is causing the issue and will push a fix in a minute.

[PromoFaux]

I wonder maybe we could update to the latest 2.x version while at it?

Huh, I could have sworn I grabbed the latest 2.4.x version, perhaps not!

Something is strange here, look at the colors in this graph:

I took the colours from the documentation of AdminLTE <2.4 I may have got them wrong, of course!

[XhmikosR]

It seems another class is missing from body too hold-transition BTW.

[DL6ER]

I fixed the color issue in 2314a60. @XhmikosR You missed the Sign-Off in your commit. Do you want to signal your agreement in a comment? We can then set DCO to pass manually.

[XhmikosR]

@DL6ER I don't mind, you even squash it with the other patches which I personally prefer :)

Addressed the color issue

[DL6ER]

@PromoFaux I see strange artifacts when scrolling with your last push. Something seems broken with 2.4.18.

git checkout 2314a60d
# Everything is fine

git checkout 9bf9e3b8
# I get lags when scrolling

I will try to record a GIF.

[PromoFaux]

That's odd.. seems OK to me when scrolling. Did you clear cache? I will await your gif :)

[DL6ER]

Yes, I cleared the cache and force-refreshed.

See the odd dark blocks when scrolling. They are absent one commit earlier (again cleared cache before trying that).

I'm using:

[DL6ER]

Confirmed fixed after a Firefox update.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1