Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "zero" delays in the Query Log #1421

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 2, 2020

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

See title.

Wrong:
Screenshot from 2020-06-02 13-21-44

Correct:
Screenshot from 2020-06-02 13-22-14

How does this PR accomplish the above?:

On fast machines, cache replies can be served within less than 100 nanoseconds. The query log should show "(0.0ms)" in this case instead of hiding the value altogether.

What documentation changes (if any) are needed to support this PR?:

None

…noseconds. The query log should show "(0.0ms)" in this case instead of hiding the value altogether.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added the Bugfix label Jun 2, 2020
@DL6ER DL6ER added this to the v5.1 milestone Jun 2, 2020
@DL6ER DL6ER requested a review from a team June 2, 2020 11:23
@PromoFaux PromoFaux merged commit 4f2d3c0 into devel Jun 2, 2020
@PromoFaux PromoFaux deleted the tweak/zero_delay_is_possible branch June 2, 2020 15:44
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants