Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $ instead of jQuery. #1385

Merged
merged 1 commit into from
May 28, 2020
Merged

Use $ instead of jQuery. #1385

merged 1 commit into from
May 28, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 26, 2020 •
edited
Loading

Signed-off-by: XhmikosR xhmikosr@gmail.com

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

@XhmikosR
Copy link
Contributor Author

Should work fine, but I can't test right now because devel throws.

@XhmikosR
Use $ instead of jQuery.
bf4ba1b 
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR force-pushed the XhmikosR-patch-3 branch from 9aa6537 to bf4ba1b Compare May 27, 2020 08:56
PromoFaux
PromoFaux approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PromoFaux PromoFaux merged commit ac8ece7 into devel May 28, 2020
@PromoFaux PromoFaux deleted the XhmikosR-patch-3 branch May 28, 2020 21:04
@XhmikosR XhmikosR added this to the v5.1 milestone May 29, 2020
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
Merged
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

Assignees
No one assigned
Labels
Code maintenance Requires Testing
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @pralor-bot @PromoFaux