Update jQuery to v3.5.1.

[XhmikosR]

Signed-off-by: XhmikosR xhmikosr@gmail.com

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)
• I have Signed Off all commits. (git commit --signoff)

---

I tested it as much as I could and it seems to work OK. Things that could break are one of the jQuery plugins, so we should test them out as good as possible.

It's not urgent to update, but we should try to do it ASAP. There have been several bugxifes, security fixes and plenty of performance improvements.

Browser support should be what we currently support, and I doubt anyone sane would use IE < 9 😛: https://jquery.com/upgrade-guide/3.0/#browser-support

I'm going to go through each of the breaking changes and see if we have code that's using that.

https://jquery.com/upgrade-guide/3.0/

This would leave us 3rd-party code only.

TODO:

• Test notify plugin
• Test jquery confirm plugin
• Test select plugin
• Test toggle plugin
• Address the .context() instances in our code
• Address any newly added TODOs

Fixes #1014

[XhmikosR]

I added a TODO in the OP.

From my tests, this has a clear positive effect on load. We should definitely do it after we test the TODO. 🙂

[XhmikosR]

I'm going to split some of the patches that can land on develop later so that this branch is only left with the jQuery 3.x update.

[XhmikosR]

I'm gonna take a stab at fixing the TODO so that we can test this further, tops until tomorrow.

I'm not sure if we want to land this in v5.1.0, but the difference is pretty big IMO.

[PromoFaux]

Test select plugin

Not sure what I'm looking for to test here, any pointers welcome

[XhmikosR]

Should be OK, I meant bootstrap-select. But all of the plugins are up to date so they should be fine.

The only plugin that's old is jquery-confirm. So if that works too, we should be fine.

EDIT: for what is worth that's one of the reasons I have it in my TODO (#1352) to remove jquery-confirm and use Bootstrap's alerts. But if it still works, it's not something we need to do for 5.1.0.

[PromoFaux]

Tested on all pages, no unexpected errors in console log. Not sure if further testing is required...

[XhmikosR]

We should be OK hopefully. Unless I missed another breaking change, but hey, mistakes can happen and we can fix them if reported.

[XhmikosR]

I mean the 3.x BC are a lot, so I tried to check every one of them in our code: https://jquery.com/upgrade-guide/3.0/

The plugins are all updated, so that's something too.

[yubiuser]

Not sure if it fits here, but there were some changes concerning "hidden" in 3.5.1.

I see now this:

[XhmikosR]

I already mentioned this somewhere else, but I don't think it's related to this change. Either way, please open new issues and don't comment on old ones because it's hard to track stuff.

[XhmikosR]

#1161 (comment)

[yubiuser]

#1457

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1