Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glyphicons again. #1341

Merged
merged 1 commit into from
May 23, 2020
Merged

Remove glyphicons again. #1341

merged 1 commit into from
May 23, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 21, 2020

Signed-off-by: XhmikosR xhmikosr@gmail.com

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

We should never use glyphicons in the codebase. We are using Font Awesome for icons. Glyphicons are removed from Bootstrap 4.x/AdminLTE 3.

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
@PromoFaux PromoFaux merged commit 685f262 into devel May 23, 2020
@PromoFaux PromoFaux deleted the rm-glyphicons branch May 23, 2020 07:12
@XhmikosR XhmikosR added this to the v5.1 milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants