Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glyphicons again. #1341

Merged
merged 1 commit into from
May 23, 2020
Merged

Remove glyphicons again. #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions scripts/pi-hole/js/groups-adlists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,12 +243,7 @@ function addAdlist() {
success: function (response) {
utils.enableAll();
if (response.success) {
utils.showAlert(
"success",
"glyphicon glyphicon-plus",
"Successfully added adlist",
address
);
utils.showAlert("success", "fas fa-plus", "Successfully added adlist", address);
table.ajax.reload(null, false);
$("#new_address").val("");
$("#new_comment").val("");
Expand Down Expand Up @@ -362,12 +357,7 @@ function deleteAdlist() {
success: function (response) {
utils.enableAll();
if (response.success) {
utils.showAlert(
"success",
"glyphicon glyphicon-trash",
"Successfully deleted adlist ",
address
);
utils.showAlert("success", "far fa-trash-alt", "Successfully deleted adlist ", address);
table.row(tr).remove().draw(false).ajax.reload(null, false);
} else {
utils.showAlert("error", "", "Error while deleting adlist with ID " + id, response.message);
Expand Down
9 changes: 2 additions & 7 deletions scripts/pi-hole/js/groups-clients.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ function editClient() {
if (response.success) {
utils.showAlert(
"success",
"glyphicon glyphicon-pencil",
"fas fa-pencil-alt",
"Successfully " + done + " client",
ip_name
);
Expand Down Expand Up @@ -400,12 +400,7 @@ function deleteClient() {
success: function (response) {
utils.enableAll();
if (response.success) {
utils.showAlert(
"success",
"glyphicon glyphicon-trash",
"Successfully deleted client ",
ip_name
);
utils.showAlert("success", "far fa-trash-alt", "Successfully deleted client ", ip_name);
table.row(tr).remove().draw(false).ajax.reload(null, false);
reload_client_suggestions();
} else {
Expand Down