Enable a couple xo (ESLint) rules and rename utils #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
May 22, 2020
| @@ -32,10 +32,11 @@ function eventsource() { | |||
| } | |||
|
|
|||
| // Detect ${OVER} | |||
| if (e.data.indexOf("<------") !== -1) { | |||
| var newString = "<------"; | |||
There was a problem hiding this comment.
I decided to cache the string while at it.
XhmikosR
changed the title
8 tasks
XhmikosR
force-pushed
the
xo-rules
branch
2 times, most recently
from
a6cd6be to
45b235a
Compare
It's a common convention to use camelcase for variable names. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Set properties to false for now. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
It's not used only in group pages, and we should try to move more common stuff here later. Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
PromoFaux
approved these changes
May 23, 2020
Merged
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}{Please ensure that your pull request is for the 'devel' branch!}git rebase)git commit --signoff)CC me if this needs a rebase, or if any other PR needs a rebase after this.