Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo - There should be a non-breaking space between the numbers and units for temperature #422

Closed
3 tasks done
MattAKAFred opened this issue Mar 2, 2017 · 2 comments
Closed
3 tasks done

Comments

@MattAKAFred
Copy link

In raising this issue, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your issue:

How familiar are you with the codebase?:

1


[BUG | ISSUE] Expected Behaviour:
non-breaking space between temperature value (eg 90) and units (eg °F), read 90 °F, following http://www.bipm.org/en/publications/si-brochure/section5-3-3.html

[BUG | ISSUE] Actual Behaviour:
No space. 90°F

[BUG | ISSUE] Steps to reproduce:

  • Load admin UI with temperature monitor
  • Look

Scientist here, sorry about the OCD, just caught my eye. Should be a quick and pain-free fix!

@DL6ER
Copy link
Member

DL6ER commented Mar 4, 2017

non-breaking space between temperature value (eg 90) and units (eg °F), read 90 °F, following ...

i.e. 25 °C

why didn't you propose that in #429 but use an ordinary whitespace there?

@barisi
Copy link
Contributor

barisi commented Mar 4, 2017

I've updated the code to have a non-breaking space instead of single whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants