-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added space between temperature reading and unit #429
Conversation
Approved @Mcat12 will have to re-approve this PR, since you made changes since the last time he approved your code. |
Sorry to be nitpicking about this, but if you add a non-breaking space before the temperature unit, please also add one before the percent sign at the end of line 351 in header.php. E. g. |
English style guides prescribe writing the number and percent sign without any space between:
See e.g. here. However, the SI handbook in fact describes the percentage sign
See e.g. here. In the end, it might be better to stick to the SI recommendations. How about finding a middle way and use a thin space in between the number and the percentage? Might also be worth to test this for the units: |
I've updated the code to have |
By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:
Please submit all pull requests against the
development
branch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
3
_Updated the rendering of temperature readings to include a space between the reading and the unit as suggested in issue #422 _
This template was created based on the work of
udemy-dl
.