Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the escaping for settings datatable #2106

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fixes PR #2100.
This time, the code fixes the right spot.

How does this PR accomplish the above?:

Please refer to #2100 description.

What documentation changes (if any) are needed to support this PR?:

none

This time, fixing the right spot.

Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit 7457f68 into devel Jan 31, 2022
@rdwebdesign rdwebdesign deleted the fix_fixescaping branch January 31, 2022 21:01
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants