Disable prettiers no-else-return rule #2166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
Prettier has a
no-else-after-return rule
which errors if anelse
statement follows anif
clause with areturn
.https://eslint.org/docs/rules/no-else-return
Although it is technically correct to omit the
else
, I think it greatly enhances the readability of the code. Additionally, the code will not fail, if thereturn
within theif
will be removed by a code change in the future.Disabling the rule has no negative consequences: the
else
is not mandatory.How does this PR accomplish the above?:
Disables the rule by setting
"no-else-return": "off"
inpackage.json