Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get port number directly from pihole-FTL.conf #2371

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

This PR simplifies the method used get the port used by FTL.

Please read the details on pi-hole/FTL#1445.

How does this PR accomplish the above?

  • Remove the old code using FTL portfile
  • code simplification

What documentation changes (if any) are needed to support this PR?

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

- Remove the code using FTL portfile
- code simplification

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants