-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart.js
from 2.9.4 to 3.9.1.
#2373
Conversation
60fee99
to
f5a5033
Compare
0f6e044
to
31e89dd
Compare
Hi @yubiuser, I want to contribute to AdminLTE project, can you please help with local setup (Windows) of this project? |
Do you have a webserver installed? |
@yubiuser, Yes, I have xampp server.. |
The webinterface is tightly coupled with the Pi-hole binary |
44e69a2
to
999a67a
Compare
2624898
to
d904cf4
Compare
I also see the spinners on the same place in
Edit: The spinner uses a fontawesome icon. This icon is replaced (and resized and repositioned) by script. |
Spinner is fixed by #2385 |
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
…ove it from the distributed version (chartjs/chartjs-adapter-moment#34) but kept the reference in the js file. I compiled it myself to generate the source map Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
…sect to false Signed-off-by: Christian König <ckoenig@posteo.de>
…argins Signed-off-by: Christian König <ckoenig@posteo.de>
…ess detailed tooltip on doughnut charts if nothing is hidden Signed-off-by: Christian König <ckoenig@posteo.de>
What does this PR aim to accomplish?:
Update
chart.js
from 2.9.4 to 3.9.1.Needed to add
chartjs-adapater-moment.js
. I tried to be as close as possible to the old visual style. A few unnecessary options were removed, some defaults were explicitly set (e.g.responsive: true
).Useful for review: https://www.chartjs.org/docs/3.4.1/getting-started/v3-migration.html
By submitting this pull request, I confirm the following:
git rebase
)