Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addding more than one local DNS/CNAME record #2410

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 21, 2022

What does this PR aim to accomplish?:

Adds the ability to add multiple local DNS records/CNAMEs via web interface (comma-separated). The code for adding multiple CNAME records was written already, but missed the last step (a loop to add them) so only one record was added.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team October 21, 2022 09:26
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Oct 21, 2022
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, going ➡️ devel now

@DL6ER DL6ER merged commit 807ea10 into devel Oct 28, 2022
@DL6ER DL6ER deleted the multiple_domains branch October 28, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants