Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale cache query status #2421

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Add stale cache query status #2421

merged 3 commits into from
Nov 14, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 7, 2022

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

See title

To be able to review this PR, you have to:

  1. Run FTL on branch update/dnsmasq (Update embedded dnsmasq to v2.88test3 FTL#1469)
  2. Add use-stale-cache to any of your *.conf files in /etc/dnsmasq.d/

An example of what you will see:

Screenshot 2022-11-07 at 14-14-10 Pi-hole - ryzen

The green box at the end shows the first queries to this domain (it is frequently queried as long as you have https://discourse.pi-hole.net/ open). Notice the almost 100 msec delay. This domain has a particularly small TTL making it an ideal test case for this.

Typically, once the query expired (orange box), it'd have to be forwarded again, causing an additional delay of (again) roughly 100ms until the reply arrived and can be forwarded to the client. However, with use-stale-cache, FTL instead immediately replies with the "old" data and does a lookup of this domain in the background (not logged). You see that subsequent queries are again served from cache as usual as the background lookup already succeeded. If it would not have arrived, FTL would again serve stale data from cache and retried the cache-refreshing lookup.

How does this PR accomplish the above?:

Add interpretation of the new query status 17

Link documentation PRs if any are needed to support this PR:

TBD


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@DL6ER DL6ER marked this pull request as ready for review November 7, 2022 13:55
@DL6ER DL6ER requested a review from a team November 7, 2022 13:55
db_queries.php Outdated Show resolved Hide resolved
@DL6ER DL6ER requested a review from rdwebdesign November 9, 2022 19:57
rdwebdesign
rdwebdesign previously approved these changes Nov 9, 2022
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdwebdesign
Copy link
Member

@yubiuser
Copy link
Member

yubiuser commented Nov 9, 2022

Interestingly, statistics[1]

https://github.com/pi-hole/AdminLTE/blob/57fd6b7adcf5a4b5a21eb784e370c68fbbc794d8/scripts/pi-hole/js/db_queries.js#L185-L186

Is never used. Maybe we need to revise our percentage calculation.

@yubiuser
Copy link
Member

Needs rebase.

DL6ER and others added 3 commits November 14, 2022 19:02
Signed-off-by: DL6ER <dl6er@dl6er.de>
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>
Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Nov 14, 2022

Rebase done. Sorry, I missed your message @yubiuser

@rdwebdesign rdwebdesign merged commit c9a7d5d into devel Nov 14, 2022
@rdwebdesign rdwebdesign deleted the new/stale-cache branch November 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants