-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale cache query status #2421
Conversation
e5bc86b
to
a6ba686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be added here (excluded), otherwise they will count as exact blocked
Or on the next line (cached): |
Interestingly, Is never used. Maybe we need to revise our percentage calculation. |
Needs rebase. |
Signed-off-by: DL6ER <dl6er@dl6er.de>
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>
Signed-off-by: DL6ER <dl6er@dl6er.de>
8ea4904
to
ec1e543
Compare
Rebase done. Sorry, I missed your message @yubiuser |
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
See title
To be able to review this PR, you have to:
update/dnsmasq
(Update embedded dnsmasq to v2.88test3 FTL#1469)use-stale-cache
to any of your*.conf
files in/etc/dnsmasq.d/
An example of what you will see:
The green box at the end shows the first queries to this domain (it is frequently queried as long as you have https://discourse.pi-hole.net/ open). Notice the almost 100 msec delay. This domain has a particularly small TTL making it an ideal test case for this.
Typically, once the query expired (orange box), it'd have to be forwarded again, causing an additional delay of (again) roughly 100ms until the reply arrived and can be forwarded to the client. However, with
use-stale-cache
, FTL instead immediately replies with the "old" data and does a lookup of this domain in the background (not logged). You see that subsequent queries are again served from cache as usual as the background lookup already succeeded. If it would not have arrived, FTL would again serve stale data from cache and retried the cache-refreshing lookup.How does this PR accomplish the above?:
Add interpretation of the new query status 17
Link documentation PRs if any are needed to support this PR:
TBD
By submitting this pull request, I confirm the following:
git rebase
)