Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-scheme: dark to fix #2554: browser not detecting dark mode #2555

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

SodaWithoutSparkles
Copy link
Contributor

@SodaWithoutSparkles SodaWithoutSparkles commented Mar 23, 2023

What does this PR aim to accomplish?:

fix #2554: browser not detecting that dark mode is already used and attempts to apply force-dark-mode, ruining the site's look

How does this PR accomplish the above?:

Add color-scheme: dark; to the html section of all .css files related to dark mode.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: SodaWithoutSparkles <64138578+SodaWithoutSparkles@users.noreply.github.com>
@rdwebdesign rdwebdesign merged commit 7c2ebef into pi-hole:devel Apr 8, 2023
@SodaWithoutSparkles
Copy link
Contributor Author

Shall I delete the branch now that it is merged?

@yubiuser
Copy link
Member

yubiuser commented Apr 8, 2023

The branch is on your fork, you can do as you want.

@DL6ER DL6ER mentioned this pull request May 28, 2023
@SodaWithoutSparkles SodaWithoutSparkles deleted the fix/dark-theme branch May 28, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High-contrast theme ruined by browser forcing dark mode
3 participants