Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the reversed logic #2597

Merged
merged 1 commit into from
May 28, 2023
Merged

Fixing the reversed logic #2597

merged 1 commit into from
May 28, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fixing an issue where some Top List items where empty.

How does this PR accomplish the above?

The issue was caused by a recent PR, where every negative expression use in comparisons where changed to positive comparisons. This reversed the logic for many if-else blocks, but one was forgotten.

This PR fixes the forgotten code.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
yubiuser referenced this pull request May 28, 2023
Signed-off-by: Christian König <ckoenig@posteo.de>
@rdwebdesign rdwebdesign linked an issue May 28, 2023 that may be closed by this pull request
@rdwebdesign rdwebdesign requested a review from a team May 28, 2023 18:39
@PromoFaux PromoFaux merged commit 6964e8c into devel May 28, 2023
@PromoFaux PromoFaux deleted the fix/reversed_logic branch May 28, 2023 19:39
@PromoFaux PromoFaux mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top Clients (blocked only) shows empty page
3 participants