Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude lists: allow also domains without TLD #303

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Dec 27, 2016

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


My previous domain validation scheme requires a TLD to be set (e.g. pi-hole.net or even pi.hole). With this PR, local domain names are not enforced to have a TLD (e.g. raspberrypi).

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added this to the v2.3 milestone Dec 27, 2016
@DL6ER DL6ER changed the base branch from master to devel December 27, 2016 17:49
@AzureMarker
Copy link
Contributor

AzureMarker commented Dec 27, 2016

Approved

Approved with PullApprove

@AzureMarker AzureMarker merged commit 21a21d8 into devel Dec 27, 2016
@AzureMarker AzureMarker deleted the fix/excludelist_allow_noTLD branch December 27, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants