Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple domains separated by whitespace #343

Merged
merged 4 commits into from
Jan 8, 2017
Merged

Conversation

AzureMarker
Copy link
Contributor

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Allow multiple domains to be added to the white/black list if separated by whitespace.

This template was created based on the work of udemy-dl.

@DL6ER
Copy link
Member

DL6ER commented Jan 8, 2017

Tried adding abc.de def.de fgh.com.
The first two succeeded but the last one failed (red info box Something failed). THe problem seems to be that you call add(domain) once per domain. But this requires restarting dnsmasq multiple times and things simply go wrong when calling multiple pihole -w ... at the same time.

@DL6ER
Copy link
Member

DL6ER commented Jan 8, 2017

Approved

Approved with PullApprove

@AzureMarker
Copy link
Contributor Author

Approved

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/entering-multiple-regex-at-one-time/20352/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants