Add static DHCPv4 leases settings #376
Conversation
…ding more than one entry with the same MAC address
|
Can you please explain why the MAC address is mandatory? DNSMasq also works nice if you specify a hostname and the IP it should get, very handy if you don't know the MAC but do know the hostname... |
|
From
We cannot detect if multiple hosts are asking for the same address (because they have the same host name, like |
|
That's true, but that's up to the administrator to make sure hostnames are unique. |
|
Well, still people might bring laptops and/or smartphones to your WiFi and you might give them the password without thinking that their devices could have a bad host name. Imagine you have a Win phone whose host name is just |
|
I agree, in that case leave it like it is. |
I think we should really leave that for professionals. However, I will have to adapt the translation routines so your results will still be display correctly. |
I am ;-)
That would be nice! |
|
|
…s this has been added manually, don't allow deleting it
|
Looks good! |
…-past into static DHCP leases table
…here when the user applies custom sorting)
| if(!strlen($error)) | ||
| { | ||
| exec("sudo pihole -a removestaticdhcp ".$mac); | ||
| $success .= "The static address with MAC address ".htmlentities($mac)." has been added"; |
|
Approved. |
By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?: 10
Add static DHCPv4 leases settings to Settings page. Batch-processing is not supported (add one entry at a time).
Backend changes: pi-hole/pi-hole#1170
This template was created based on the work of
udemy-dl.