Added online debug log creator

[DL6ER]

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10

---

Calls sudo pihole -d -a

This template was created based on the work of udemy-dl.

[dschaper]

sudo pihole -d -a is going to be the trigger then?

[DL6ER]

Yes. it can still be changed if you'd like to have something different

[dschaper]

LGTM.

[PromoFaux]

Can we not make it an optional upload still?

I'm thinking Modal dialog box with a "Would you like to upload the debug log once it has completed?" before the script runs.

OR alternatively a button that will just run the nc command to upload /var/log/pihole_debug.log at the end?

tl;dr I don't like (And therefore some users are not going to like) not giving users a choice.

[DL6ER]

I'm thinking Modal dialog box with a "Would you like to upload the debug log once it has completed?" before the script runs.

Yeah, that is possible, depending on that we can then decide whether to call pihole -d or pihole -d -a

[dschaper]

pihole -d will still block though, it's going to wait for user interaction. There's probably going to be more flags needed to be passed, one for auto-no upload and one for auto-with upload. Unless there's another way around the issue.

Edit: NoTTY's don't block for read.

[PromoFaux]

Maybe just lower the blocking time at the end of the script, take the interaction out of it and make it mandatory...

[dschaper]

It has the timeout now, so it will stop the log capture, but then it still requires a Y/N for log upload. If the solution is that pihole -d auto-uploads, then that's a problem.

[DL6ER]

it still requires a Y/N for log upload

The pipe that is opened by our PHP script is read-only, hence read will fail (as if saying "No"). In fact, there is no problem:

• pihole -d won't try to upload,
• pihole -d -a will try to upload.

[dschaper]

Yeah, I see now that it's no-TTY, so read fails, the script sees that as a non=y answer and doesn't attemtp to upload.

[AzureMarker]

Should re-enable the button and checkbox when finished.

[dschaper]

I'd like to keep that as it is. Force the users to at least reload the page before sending another debug.

[dschaper]

Approved

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-2-13-core-2-5-web/2004/1