Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DHCP leases table always #478

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Show DHCP leases table always #478

merged 2 commits into from
Apr 21, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Apr 21, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?: 10


Show DHCP leases table (will be empty) and allow editing of static leases also when DHCP server is not enabled. A number of users have reported that they hesitated to migrate away from their router's DHCP server to Pi-hole's since they were not aware of the possibility to add static leases.

Now we show the table always. The dynamic leases table will be empty as long as the DHCP server is disabled.
screenshot at 2017-04-21 23-46-57

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added this to the v3.0 milestone Apr 21, 2017
@DL6ER DL6ER merged commit 20f5eb8 into devel Apr 21, 2017
@DL6ER DL6ER deleted the tweak/DHCP_staticleases branch April 21, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants