Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Add parent folder for increased code modularity. #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielAtKrypton
Copy link

@DanielAtKrypton DanielAtKrypton commented Feb 7, 2021

With these changes, for example, it becomes possible to call the functions from other than root paths. This repository is a good example in which manual-connections is a git submodule.

@g00nix
Copy link
Contributor

g00nix commented Feb 21, 2021

Thank you for your PR!

We will have to test this on all distributions before approving this merge. Did you have any time to test this on a few systems to make sure it doesn't break compatibility?

@DanielAtKrypton
Copy link
Author

@g00nix , I tested in Debian inside WSL2. The changes are not critical and are well accepted within the Linux eco-system. To be on the safe side, before merging, let me add Travis for continuous integration tests in some Linux machines and also within MacOS systems.

@dacabdi
Copy link

dacabdi commented Feb 24, 2022

closes #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants