Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KM-5043: Dismiss any other view that is presented before showing Force Update #172

Merged
merged 1 commit into from
Oct 10, 2024
Merged

KM-5043: Dismiss any other view that is presented before showing Force Update #172

merged 1 commit into from
Oct 10, 2024

Conversation

kp-laura-sempere
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere commented Oct 10, 2024 •
edited
Loading

  • When the Flag for force update gets enabled, the app might be in a state where any other view could be modally presented over the current context like settings, menu, options, etc. So we want to make sure that the Force Update screen is presented when intended also in those scenarios.

For more information, see the CONTRIBUTING readme or the contributing guide.

Summary

This PR fixes/implements the following bugs/features

  • Force Update Feature Enhancement

kp-said-rehouni
kp-said-rehouni approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kp-said-rehouni kp-said-rehouni merged commit effc428 into master Oct 10, 2024
0 of 2 checks passed
@kp-said-rehouni kp-said-rehouni deleted the KM-5043_update_force_update_presentation branch October 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-said-rehouni kp-said-rehouni kp-said-rehouni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-laura-sempere @kp-said-rehouni