Merge pull request #28 from picazin:picazin/issue27

Initial object id error
picazin · Oct 9, 2020 · a5b136d · a5b136d
2 parents 899a56a + 5b14f5b
commit a5b136d
Show file tree

Hide file tree

Showing 10 changed files with 113 additions and 59 deletions.
diff --git a/.vscode/picazin.ruleset.json b/.vscode/picazin.ruleset.json
@@ -2,35 +2,20 @@
     "name": "picazin",
     "description": "picazin rules",
     "rules": [
-        {
-            "id": "AA0214",
-            "action": "Hidden",
-            "justification": "WTF?!?! - The local record should be modified before saving to the database."
-        },
         {
             "id": "AA0218",
             "action": "Hidden",
             "justification": "No efficient - You must write a tooltip in the Tooltip property for all controls of type Action and Field that exist on page objects. See the style guide for more information."
         },
         {
-            "id": "AW0006",
-            "action": "Hidden",
-            "justification": "No need all objects to be searchable."
-        },
-        {
-            "id": "AS0084",
-            "action": "Hidden",
-            "justification": "No AppSource extension"
-        }        ,
-        {
-            "id": "AS0085",
+            "id": "AA0072",
             "action": "Hidden",
-            "justification": "No AppSource extension"
+            "justification": "WTF?!?!"
         },
         {
-            "id": "AA0072",
+            "id": "AW0006",
             "action": "Hidden",
-            "justification": "WTF?!?!"
+            "justification": "No need all objects to be searchable."
         },
         {
             "id": "AL0604",

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -2,7 +2,7 @@
     "al.codeAnalyzers": [
         "${CodeCop}",
         "${UICop}",
-        "${AppSourceCop}"
+        "${PerTenantExtensionCop}"
     ],
     "al.ruleSetPath": ".vscode/picazin.ruleset.json",
     "CRS.FileNamePattern": "<ObjectNameShort>.<ObjectTypeShortPascalCase>.al",

diff --git a/Translations/Extension Manager.es-ES.g.xlf b/Translations/Extension Manager.es-ES.g.xlf
@@ -371,6 +371,12 @@
           <note from="Xliff Generator" annotates="general" priority="3">Page EXM Extension Header - Control Object Ending ID - Property Caption</note>
           <target>Nº final</target>
         </trans-unit>
+        <trans-unit id="Page 2608205474 - Method 4177352842 - NamedType 2218492339" size-unit="char" translate="yes" xml:space="preserve">
+          <source>%1 should have value.</source>
+          <note from="Developer" annotates="general" priority="2">ESP="%1 deberia tener valor."</note>
+          <note from="Xliff Generator" annotates="general" priority="3">Page EXM Extension Header - Method OnQueryClosePage - NamedType EmptyIDMsg</note>
+          <target>%1 deberia tener valor.</target>
+        </trans-unit>
         <trans-unit id="Table 70614016 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve">
           <source>Extension Objects</source>
           <note from="Developer" annotates="general" priority="2">ESP="Objetos extensión"</note>

diff --git a/Translations/Extension Manager.g.xlf b/Translations/Extension Manager.g.xlf
@@ -318,6 +318,11 @@
           <note from="Developer" annotates="general" priority="2">ESP="Nº final"</note>
           <note from="Xliff Generator" annotates="general" priority="3">Page EXM Extension Header - Control Object Ending ID - Property Caption</note>
         </trans-unit>
+        <trans-unit id="Page 2608205474 - Method 4177352842 - NamedType 2218492339" size-unit="char" translate="yes" xml:space="preserve">
+          <source>%1 should have value.</source>
+          <note from="Developer" annotates="general" priority="2">ESP="%1 deberia tener valor."</note>
+          <note from="Xliff Generator" annotates="general" priority="3">Page EXM Extension Header - Method OnQueryClosePage - NamedType EmptyIDMsg</note>
+        </trans-unit>
         <trans-unit id="Table 70614016 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve">
           <source>Extension Objects</source>
           <note from="Developer" annotates="general" priority="2">ESP="Objetos extensión"</note>

diff --git a/app.json b/app.json
@@ -2,7 +2,7 @@
   "id": "b9954c96-ee6b-44ff-9b0d-3d8146fc034a",
   "name": "Extension Manager",
   "publisher": "picazin dev",
-  "version": "0.2.9.4",
+  "version": "0.3.0.0",
   "brief": "Manager for developing extensions.",
   "description": "Manage your extension data. Development status. Customers, invoicing and all related data.",
   "privacyStatement": "http://www.picazin.dev",

diff --git a/extensionsPermissionSet.xml b/extensionsPermissionSet.xml
@@ -101,6 +101,26 @@
       <ExecutePermission>1</ExecutePermission>
       <SecurityFilter />
     </Permission>
+    <Permission>
+      <ObjectID>83206</ObjectID>
+      <ObjectType>0</ObjectType>
+      <ReadPermission>1</ReadPermission>
+      <InsertPermission>1</InsertPermission>
+      <ModifyPermission>1</ModifyPermission>
+      <DeletePermission>1</DeletePermission>
+      <ExecutePermission>0</ExecutePermission>
+      <SecurityFilter />
+    </Permission>
+    <Permission>
+      <ObjectID>83206</ObjectID>
+      <ObjectType>1</ObjectType>
+      <ReadPermission>0</ReadPermission>
+      <InsertPermission>0</InsertPermission>
+      <ModifyPermission>0</ModifyPermission>
+      <DeletePermission>0</DeletePermission>
+      <ExecutePermission>1</ExecutePermission>
+      <SecurityFilter />
+    </Permission>
     <Permission>
       <ObjectID>83207</ObjectID>
       <ObjectType>0</ObjectType>
@@ -142,7 +162,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83206</ObjectID>
+      <ObjectID>83208</ObjectID>
       <ObjectType>0</ObjectType>
       <ReadPermission>1</ReadPermission>
       <InsertPermission>1</InsertPermission>
@@ -152,7 +172,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83206</ObjectID>
+      <ObjectID>83208</ObjectID>
       <ObjectType>1</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -221,6 +241,26 @@
       <ExecutePermission>1</ExecutePermission>
       <SecurityFilter />
     </Permission>
+    <Permission>
+      <ObjectID>83219</ObjectID>
+      <ObjectType>8</ObjectType>
+      <ReadPermission>0</ReadPermission>
+      <InsertPermission>0</InsertPermission>
+      <ModifyPermission>0</ModifyPermission>
+      <DeletePermission>0</DeletePermission>
+      <ExecutePermission>1</ExecutePermission>
+      <SecurityFilter />
+    </Permission>
+    <Permission>
+      <ObjectID>83220</ObjectID>
+      <ObjectType>8</ObjectType>
+      <ReadPermission>0</ReadPermission>
+      <InsertPermission>0</InsertPermission>
+      <ModifyPermission>0</ModifyPermission>
+      <DeletePermission>0</DeletePermission>
+      <ExecutePermission>1</ExecutePermission>
+      <SecurityFilter />
+    </Permission>
     <Permission>
       <ObjectID>83213</ObjectID>
       <ObjectType>8</ObjectType>
@@ -322,7 +362,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83207</ObjectID>
+      <ObjectID>83217</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -332,7 +372,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83212</ObjectID>
+      <ObjectID>83216</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -342,7 +382,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83204</ObjectID>
+      <ObjectID>83218</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -352,7 +392,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83206</ObjectID>
+      <ObjectID>83207</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -362,7 +402,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83216</ObjectID>
+      <ObjectID>83212</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -372,7 +412,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83218</ObjectID>
+      <ObjectID>83204</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -382,7 +422,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>83217</ObjectID>
+      <ObjectID>83206</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>

diff --git a/src/codeunit/EXMInstallSetup.Codeunit.al b/src/codeunit/EXMInstallSetup.Codeunit.al
@@ -59,4 +59,9 @@ codeunit 83201 "EXM Install Setup"
         ExtEnum.ModifyAll("Customer No.", ExtHeader."Customer No.");
     end;
 
+    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Company-Initialize", 'OnCompanyInitialize', '', false, false)]
+    local procedure CompanyInitialize()
+    begin
+
+    end;
 }
diff --git a/src/page/EXMExtensionHeader.Page.al b/src/page/EXMExtensionHeader.Page.al
@@ -107,10 +107,15 @@ page 83201 "EXM Extension Header"
     end;
 
     trigger OnQueryClosePage(CloseAction: Action): Boolean
+    var
+        EmptyIDMsg: Label '%1 should have value.', comment = 'ESP="%1 deberia tener valor."';
     begin
         if Code <> '' then begin
-            TestField("Object Starting ID");
-            TestField("Object Ending ID");
+            if Rec."Object Starting ID" = 0 then
+                Message(StrSubstNo(EmptyIDMsg, Rec.FieldCaption("Object Starting ID")));
+
+            if Rec."Object Ending ID" = 0 then
+                Message(StrSubstNo(EmptyIDMsg, Rec.FieldCaption("Object Ending ID")));
         end;
     end;
 }