Feat/univ3 multisig #204
Open
Feat/univ3 multisig #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better watchlist inspection
treasury fees in native setTokenToNativeRoute single univ3 base for all chains
| _cache.amount1 | ||
| ); | ||
| } | ||
| bool _zeroForOne = _cache.amount0Desired > _cache.amount0 ? true : false; |
There was a problem hiding this comment.
I know you inherited this naming convention, but it's so confusing that amount0Desired is what you already have, and amount0 is what you desire to obtain 😅
larrythecucumber321
approved these changes
Dec 6, 2022
move polygon univ3 migration test to polygon dir
…posits and shares
…anup to compile properly
add tests for arbitrum univ3 migrations chore: cleanup obsolete files update safe-core-sdk to latest version to support safes on arbitrum
add tests for optimism univ3 migrations chore: cleanup obsolete files
add tests for mainnet univ3 migrations fix: multisigHelper ensures owner balance covers txn const
add tests for polygon univ3 migrations
update velo unit tests
add fantom sushi strategies and tests
remove discontinued arbitrum sushi strategies
remove discontinued polygon sushi strategies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.