-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new file operations mkdir, rename, delete and upload to drive service. #291
Conversation
506eda2
to
7ddad55
Compare
…vice. The drive service only supports the bare minimum right now, improve this situation. Also support upload of new files to the iCloud Drive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition, thanks !
match = search(r"\bt=([^:]+)", cookie.value) | ||
if not match: | ||
if match is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not not
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because re.search will return None for "no match found" and I thought this way it is made explicit what we're checking for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not
because it checks more.
Co-authored-by: Quentame <polletquentin74@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lost of "%s" %
.
We should remove if of all services actually, in a new PR.
@Quentame okay, I think I got all the %s indirections now. |
A |
@Quentame done... |
BTW: you might wanna have a look at https://github.com/ixs/iftp which is a ftp-styled frontend to icloud drive. I have a FUSE driver written locally, but it's not... perfect... yet... |
Cooooool ! I personally do in Home Assistant. |
The drive service only supports the bare minimum right now, improve
this situation.