Fix for drive operations requiring clientId #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Moving files to trash and creating directories when using iCloud Drive functions throws errors on lacking clientId. There are lots of bugs filed (#384 , #366, #326, and others) on this.
Most of these bugs suggest using the
api.client_id
value as the params, which does work.However, looking at icloud.com API interactions, it appears that the correct way to do this is as follows:
create_folders()
-> icloud.com uses a clientId of the formatFOLDER::UNKNOWN_ZONE::TempId-<random uuid4>
when making this call.move_items_to_trash()
- icloud.com sends theclientId
with the same value as thenode_id
.I replicated the icloud behavior instead of using the actual
api.client_id
, as that seems to be the right thing to do.Type of change
Example of code:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: