Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xUnit Test Result Provider to Deal with more than 255 Scenarios in a File #397

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

eugene-sea
Copy link

Recently we have switched to xUnit.net from MSTest for SpecFlow. Immediately we have run into issue with pickles — it is failed due to XML load exception. The issue is with XSD schema: aggregate stats are defined as unsigned bytes. This means maximum number of tests are limited to 255 but we have much more.

I have updated schema so aggregates are now int. (pickles code assumes they have signed int type.)

There is no changes in code. Only schema and generated code are updated. It is difficult to create test for this issue as number of tests in results should be greater than 255.

@dirkrombauts dirkrombauts merged commit 8881f20 into picklesdoc:master Nov 29, 2016
@dirkrombauts
Copy link
Member

Thank you for your contribution! I plan to release a new version by the end of the week.

@eugene-sea eugene-sea deleted the XUnitXMLLoadException branch November 29, 2016 14:45
@dirkrombauts dirkrombauts changed the title Changed types of aggregate stats to int instead of byte Enable xUnit Test Result Provider to Deal with more than 255 Scenarios in a File Dec 5, 2016
@dirkrombauts
Copy link
Member

Released in version 2.11.0.

@eugene-sea
Copy link
Author

Thank you

@eugene-sea
Copy link
Author

@dirkrombauts after I have updated CI to use 2.11.0 — builds are started to fail with the same issue as before ("number of tests is too big"). I have created custom build with this PR and it works. It looks like 2.11.0 does not contain this PR.

@dirkrombauts
Copy link
Member

Maybe I made a mistake when merging ... I will look into it. Thanks for letting me know!

@dirkrombauts
Copy link
Member

I see it now ... it was merged into the wrong branch. My apologies for the oversight.

@dirkrombauts
Copy link
Member

I released a corrected version in version 2.11.1.

@eugene-sea
Copy link
Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants