Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to automatically publish new releases to PyPI #114

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Jul 9, 2024

@dpgrote
Copy link
Member

dpgrote commented Jul 9, 2024

Thanks! This looks good. Two comments:

Could the same comment that was added to the README in fbpic be added here?

This uses python 3.11. Is there a reason not to use the latest, python 3.12?

dpgrote
dpgrote previously approved these changes Jul 9, 2024
Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dpgrote
Copy link
Member

dpgrote commented Jul 17, 2024

Can you also update the text in PICMI_Python/README.md, removing the comments on how to upload to PyPI?

Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@dpgrote dpgrote merged commit 5a2594a into picmi-standard:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants