Upload invoice bugfix #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The order of the 2 parameters |
|
That is unfortunate. We cannot change the Client directly, we have to make sure the generator works well. It seems to be broken when converting the v2 to the v3 definitions in #36. @WoutervanderLoopNL I see that you changed some things about the multipart uploader in the client generator. Do you quickly see what went wrong? Otherwise I will try to debug it. |
WoutervanderLoopNL
added a commit
to WoutervanderLoopNL/bol-retailer-php-client
that referenced
this pull request
Jan 3, 2024
|
Fixed in the generator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uploadInvoicefunction is broken after the last update. There was no way to actually upload the invoice, since you couldn't pass the invoice to the function. TheuploadInvoicefunction was modified in #42, and broken since then.I restored the code to the state of how it was in the previous release. That has always worked for us.
If there are any comments, please let me know!